RFR(s): 8241638: [backport] launcher time metrics always report 1 on Linux when _JAVA_LAUNCHER_DEBUG set

[Liu, Xin]

Hi, Andrew, 

Got it.  I see why "cursory check" is necessary.  Thank you to catch that!
     if (JLI_IsTraceLauncher()) {
-        end   = CounterGet();
+        end = CounterGet();

I made a typo. I am not* a reviewer. 
I will pay attention to the cursory things when I offer voluntary reviewing.   

Thanks, 
--lx

On 5/13/20, 3:38 PM, "Andrew Hughes" <gnu.andrew at redhat.com> wrote:



    On 24/04/2020 00:19, Liu, Xin wrote:
    > Hi, Zang, 
    > 
    > I am now a reviewer. I just offer helps to eyeball trivial issues.
    > 
    > The patch is almost a clean backport. As long as you declare the  patch can apply to jdk8u cleanly,  I think you can skip the formal review. 

    No. The only situation in which a formal review should be skipped is
    when all that is required is the automated conversion of the file paths,
    using the unshuffle scripts.

    When manual work needs to be done, at least a cursory check is required.

    Thanks,
    -- 
    Andrew :)

    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)

    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222