RFR(s): 8241638: [backport] launcher time metrics always report 1 on Linux when _JAVA_LAUNCHER_DEBUG set

[Andrew Hughes]

On 13/05/2020 23:59, Liu, Xin wrote:
> Hi, Andrew, 
> 
> Got it.  I see why "cursory check" is necessary.  Thank you to catch that!
>      if (JLI_IsTraceLauncher()) {
> -        end   = CounterGet();
> +        end = CounterGet();
> 
> I made a typo. I am not* a reviewer. 
> I will pay attention to the cursory things when I offer voluntary reviewing.   
> 
> Thanks, 
> --lx
> 

No worries. I usually start by getting both the 11u and the proposed 8u
changes and doing a diff between them. That immediately stood out when I
did that.

I'm a little confused as to why it got lost, because the 11u patch
applied fine to those files when I tried. It's only the Makefile that
needed manual work.

Anyway, these things get easier with experience :-)

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222