[8u] RFR: Backport of 8067796 (process) Process.waitFor(timeout, unit) doesn't throw NPE if timeout is less than, or equal to zero when unit == null

[Andrew Hughes]

On 05/04/2020 20:44, Sergey Nazarkin wrote:
> Thanks, Andrew. In simpler case 8037866(Replace the Fun class in tests with lambdas)  only misses a part of MOAT.java that was introduced by 8014066(ArrayList#removeRange):
> 
> $cat test/java/util/Collection/MOAT.java.rej
> --- MOAT.java
> +++ MOAT.java
> @@ -728,8 +722,8 @@
>          l.listIterator(0);
>          l.listIterator(l.size());
>          THROWS(IndexOutOfBoundsException.class,
> -               new Fun(){void f(){l.listIterator(-1);}},
> -               new Fun(){void f(){l.listIterator(l.size() + 1);}});
> +               () -> l.listIterator(-1),
> +               () -> l.listIterator(l.size() + 1));
> 
>          if (l instanceof AbstractList) {
>              try {
> 
> Final patchset would be
>  
> 1) http://cr.openjdk.java.net/~snazarki/webrev/8037866/
> 2) http://cr.openjdk.java.net/~snazarki/webrev/8067796/
> 
> 
> 
> Sergey Nazarkin
> 

Sorry for the delay on this.

8037866 looks fine to me and we shouldn't introduce 8014066, which may
change java.util.ArrayList behaviour.

I'll look at 8067796 again once 8037866 is pushed.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222