[8u] RFR : TLSv1.3 protocol support

[Martin Balao]

On 5/20/20 7:49 AM, Alexey Bakhtin wrote:
> Hello Martin,
> 
> About extra tests in JDK8:
> These tests and packages exist in JDK8 since initial implementation. The sun/security/ssl test directory in JDK11 has a little bit different structure: the same tests located in different subdirectories in JDK8 and JD11. I did not replace TLS 11.0.7 tests but merge them keeping original directory structure.
> May be I should apply the same review strategy for the TLS tests too : remove 8u tests, replace with 11u tests, change 8u only tests.

Oh, I see.

There are several tests in JDK-8 which in JDK-11 are located in a
different directory (out of sun/security/ssl). In example,
/sun/security/ssl/sun/net/www/protocol/https/NewImpl directory in JDK-8
is located in /jdk/sun/net/www/protocol/https/NewImpl in JDK-11. That's
the reason why I noticed so many more tests when comparing jtreg
executions between 8 and 11.

I've seen you did not replaced those files in JDK-8 -at least the 5
files I compared have differences with their JDK-11 version-. My
question is: how are we sure that we don't need updates from JDK-11? In
particular, I wonder if we are preventing TLS 1.3 code to be exercised.
And I'm also concerned about the failures there (list at the end of this
mail [1]).

Thanks,
Martin.-

--
[1] -

Error:  sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/Basics.java
Error:  sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/CheckStatus.java
Error:  sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/ConnectionTest.java
Error:
sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/EngineCloseOnAlert.java
Error:
sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/IllegalHandshakeMessage.java
Error:
sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/IllegalRecordVersion.java
Error:  sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/TestAllSuites.java
FAILED: sun/security/ssl/javax/net/ssl/NewAPIs/CheckMyTrustedKeystore.java
Error:  sun/security/ssl/sanity/ciphersuites/CipherSuitesInOrder.java
Error:
sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java