[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

Andrew Haley aph at redhat.com
Thu May 28 12:34:39 UTC 2020


On 28/05/2020 10:08, Jaroslav Bachorík wrote:
> I guess so. But such a test is not a part of the original changeset.
> Is it necessary to be extending the scope of the original patch
> (https://hg.openjdk.java.net/jdk/jdk/rev/127ca611f19b)?

Yes please. 8u is old code, and your first task is not to break it. If
this involves being more defensive than upstream, that's fine. Class
initialization order at startup is notoriously sensitive and responsible
for breaking things in subtle ways.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the jdk8u-dev mailing list