[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

[Andrew Hughes]

On 28/05/2020 13:34, Andrew Haley wrote:
> On 28/05/2020 10:08, Jaroslav Bachorík wrote:
>> I guess so. But such a test is not a part of the original changeset.
>> Is it necessary to be extending the scope of the original patch
>> (https://hg.openjdk.java.net/jdk/jdk/rev/127ca611f19b)?
> 
> Yes please. 8u is old code, and your first task is not to break it. If
> this involves being more defensive than upstream, that's fine. Class
> initialization order at startup is notoriously sensitive and responsible
> for breaking things in subtle ways.
> 

There's also no reason such a change could not then be forwardported to
later versions. If a bug is filed for this, the 8u fix can be committed
under both 8233197 & the new ID, and then the test change alone posted
for review in later versions.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222