[8u] RFR 8221408: Windows 32bit build build errors/warnings in hotspot

[Hohensee, Paul]

Hi, Zhengyu,

In os_windows_x86.cpp, the new pragma disabling C4172 unconditionally seems redundant if "defined(_MSC_VER) && _MSC_VER >= 1900" is true. 1900 means VS2015, which is why VS2017 is unaffected by your patch. And maybe C4172 wasn't checked for at all in VS2010, which is why it's not affected either. Also, there's no corresponding pragma to unconditionally re-enable the warning, which there is in the 11u patch. I agree with Alex, the new pragma doesn't seem needed, so I'd drop the change to this file.

The change to markOop.hpp looks like a good cleanup on its own though.

Thanks,
Paul

On 9/3/20, 4:47 PM, "jdk8u-dev on behalf of Alex Kashchenko" <jdk8u-dev-retn at openjdk.java.net on behalf of akashche at redhat.com> wrote:

    Hi,

    On 8/31/20, Zhengyu Gu <zgu at redhat.com> wrote:
    > I would like to backport this patch to 8u for parity with Oracle 8u281.
    >
    > The backport is based on 11u patch and it does not apply cleanly.
    >
    > 1) classFileParser.cpp: change already in 8u via JDK-8205677
    > 2) os_windows_x86.cpp: context is slightly different
    >
    > The original bug: https://bugs.openjdk.java.net/browse/JDK-8221408
    > 11u patch: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/f03e922bfcb8
    >
    > 8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8221408-8u/webrev.00/
    >
    > Test:
    >    Built 32-bit JDKs on Windows (release and fastdebug)

    I am probably missing something, but I cannot reproduce the warnings
    neither with vs2010 nor with vs2017 fastdebug 32-bit builds. It seems
    that I am getting the same set of warnings (that doesn't include
    C4172) before and after the patch. Any specific pointers how the
    warnings should look like? Or is the change in markOop.hpp is just a
    cleanup?

    --
    -Alex