[8u] RFR 8233548: Update CUP to v0.11b

Zhengyu Gu zgu at redhat.com
Wed Nov 25 16:01:38 UTC 2020


Thanks, Paul.

-Zhengyu

On 11/25/20 9:18 AM, Hohensee, Paul wrote:
> Good enough. Lgtm.
> 
> Paul
> 
> On 11/25/20, 5:45 AM, "Zhengyu Gu" <zgu at redhat.com> wrote:
> 
>      CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
>      Hi Paul,
> 
>      On 11/24/20 4:52 PM, Hohensee, Paul wrote:
>      > Hi, Zhengyu,
>      >
>      > Looks like this one got lost!
>      >
>      > Looks good, except a nit: you didn't backport the formatting for the XPathParser default and scanner constructors.
> 
>      Thanks for reviewing. I fixed formatting for the XPathParser default and
>      scanner constructors.
> 
>      Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8233548-8u/webrev.01/
> 
>      -Zhengyu
> 
>      >
>      > Maintainers, this was considered a critical fix for 11.0.7, perhaps it should be for 8u282 as well.
>      >
>      > Thanks,
>      > Paul
>      >
>      > On 3/30/20, 7:46 AM, "jdk8u-dev on behalf of Zhengyu Gu" <jdk8u-dev-bounces at openjdk.java.net on behalf of zgu at redhat.com> wrote:
>      >
>      >      Hi,
>      >
>      >      Please review this backport to upgrade CUP to v0.11b.
>      >
>      >      The original patch does not apply cleanly. Matter of fact, the backport
>      >      is mostly manual.
>      >
>      >      1) The bug is not in 8u's ProblemList.txt
>      >      2) License update is in different place.
>      >      3) Other than replacing various tables, I also replaced parser_action
>      >      class (CUP$XPathParser$actions -> parser_action) with 11u version.
>      >
>      >      Original bug: https://bugs.openjdk.java.net/browse/JDK-8233548
>      >      Original patch: https://hg.openjdk.java.net/jdk/jdk/rev/b470da55a673
>      >
>      >      8u webrev: http://cr.openjdk.java.net/~zgu/JDK-8233548-8u/webrev.00/
>      >
>      >      Test:
>      >         jdk_other which includes jaxp tests
>      >         Test case from https://bugzilla.redhat.com/show_bug.cgi?id=1327649
>      >
>      >
>      >      Thanks,
>      >
>      >      -Zhengyu
>      >
>      >
> 
> 



More information about the jdk8u-dev mailing list