[8u] RFR 8160768: Add capability to custom resolve host/domain names within the default JNDI LDAP provider

Andrew Hughes gnu.andrew at redhat.com
Wed Sep 2 16:20:01 UTC 2020


On 13:41 Fri 28 Aug     , Langer, Christoph wrote:
> Hi,
> 
> as for these @since 12 tags...
> 
> While I understand that there are both, arguments pro and con, I'd like to point out one specific thing in the context of this backport:
> Classes com.sun.jndi.ldap.spi. LdapDnsProvider and com.sun.jndi.ldap.spi. LdapDnsProviderResult don't even exist in 12 and probably won't ever. In 12 we have javax.naming.ldap.spi.LdapDnsProvider and javax.naming.ldap.spi.LdapDnsProviderResult. So, given that change of package location, I opt to remove the @since 12 tags which I'm proposing in my webrev for 11u as well.
> 
> Andrew, does that convice you or you still insist on the tags?
> 
> Cheers
> Christoph
> 

Well, I wasn't aware that I was insisting on this; I don't think it's
a huge issue either way.

I don't see a case for a general policy of removing these, because I
don't see a huge benefit to it. What is the case for removing them,
compared with the churn of creating further divergence and potentially
turning a clean backport into one that needs to be reviewed because "I
went and took out a dozen @since tags"?

I'm aware that in this case, the packages are different (and have to be
for TCK compliance). To me, the @since is an indicator of why they
are different (this is API in 12, we had to shift it elsewhere in 8u).

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list