[8u] RFR 8062947: Fix exception message to correctly represent LDAP connection failure

Andrew Hughes gnu.andrew at redhat.com
Tue Sep 8 16:45:59 UTC 2020


On 11:34 Tue 08 Sep     , Zhengyu Gu wrote:
> 
> > 	
> > Please post a webrev just containing this fix.
> 
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8062947-8u/webrev.01/
> 
> Thanks,
> 
> -Zhengyu
> 
> > 
> > Thanks,
> > 
> 

Thanks. This looks fine.

I really don't know why they use this 'var'. It just makes the code
less readable IMHO e.g.

var env = ldapServer.getInitialLdapCtxEnvironment(0);

I have no idea what env is with this.

Hashtable<Object, Object> env = ldapServer.getInitialLdapCtxEnvironment(0);

With this, I do.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list