[8u] RFR: JDK-8152545 Use preprocessor instead of compiling a program to generate native nio constants

[Andrew Hughes]

On 13:06 Fri 28 Feb     , Simon Tooke wrote:
> Hello,
> 
> I would like to request approval to backport of JDK-8152545 (Use
> preprocessor instead of compiling a program to generate native nio
> constants) to jdk8u for buildability reasons.  I've personally encountered
> toolchains where the current solution doesn't build.
> 
> I had to modify the original webrev to get rid of the SO_REUSEPORT
> definition, as it isn't supported in JDK8.
> 
> I've tested this on Windows and macos.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8152545
> 
> Original patch: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/e2e318304252
> 
> Modified webrev:
> http://cr.openjdk.java.net/~stooke/webrevs/jdk-8152545-jdk8/02/jdk.02
> 
> Thank you for your time,
> 
> -Simon
> 
> 

Looks good, other than this odd indentation + whitespace difference:

- GENSRC_MISC += $(GENSRC_UC_FILE)
+
+  GENSRC_JAVA_BASE += $(GENSRC_UC_FILE)

Fixed version: https://cr.openjdk.java.net/~andrew/openjdk8/8152545/webrev.01/jdk.patch

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222