[8u] [RFR] JDK-8272214: Build failure after backport of JDK-8248901

Andrew Hughes gnu.andrew at redhat.com
Mon Aug 16 05:12:05 UTC 2021


On 14:01 Thu 12 Aug     , Severin Gehwolf wrote:
> On Thu, 2021-08-12 at 10:34 +0200, Severin Gehwolf wrote:
> > Hi Andrew,
> > 
> > Please hold this patch for a bit longer since we are still seeing
> > Windows build failures with VS 2010 with this patch. More work will be
> > needed. It's not clear why the Adopt CI worked. One difference is VS
> > 2013 build vs. VS 2010 build, apparently.
> 
> This patch seems to be sufficient now. Basically it defines
> INT64_C/UINT64_C for VS 2010 and lower, which seems to fix the build.
> 
> https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8272214/01/webrev/
> 
> Thoughts?
> 
> Thanks,
> Severin
> 

Looks good to me. I've approved and pushed it, with an additional credit
to you, so it makes b03.

They probably could have been two separate patches, because the first
did at least fix older glibc installations.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list