[8u] [RFR] JDK-8272214: Build failure after backport of JDK-8248901

Severin Gehwolf sgehwolf at redhat.com
Mon Aug 16 08:07:11 UTC 2021


On Mon, 2021-08-16 at 06:12 +0100, Andrew Hughes wrote:
> On 14:01 Thu 12 Aug     , Severin Gehwolf wrote:
> > On Thu, 2021-08-12 at 10:34 +0200, Severin Gehwolf wrote:
> > > Hi Andrew,
> > > 
> > > Please hold this patch for a bit longer since we are still seeing
> > > Windows build failures with VS 2010 with this patch. More work will be
> > > needed. It's not clear why the Adopt CI worked. One difference is VS
> > > 2013 build vs. VS 2010 build, apparently.
> > 
> > This patch seems to be sufficient now. Basically it defines
> > INT64_C/UINT64_C for VS 2010 and lower, which seems to fix the build.
> > 
> > https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8272214/01/webrev/
> > 
> > Thoughts?
> > 
> > Thanks,
> > Severin
> > 
> 
> Looks good to me. I've approved and pushed it, with an additional credit
> to you, so it makes b03.
> 
> They probably could have been two separate patches, because the first
> did at least fix older glibc installations.


Thanks, Andrew!

Cheers,
Severin



More information about the jdk8u-dev mailing list