[UNVERIFIED SENDER] Re: [8u] RFR 8231438 [macos] The dark mode is not supported yet

[Taylor, Ben]

In XCode 12.5.1 on macos 11.4, AvailabilityVersions.h  from MacOSX.sdk includes defines for __MAC_10_0 to __MAC_11_3, so it seems safe to assume these will remain defined.

--Ben

On 8/17/21, 8:43 AM, "jdk8u-dev on behalf of Hohensee, Paul" <jdk8u-dev-retn at openjdk.java.net on behalf of hohensee at amazon.com> wrote:

    Will __MAC_10_14 remain defined for future SDK versions? If so, lgtm. Otherwise, you need some sort of >= check.

    Thanks,
    Paul

    -----Original Message-----
    From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Sergey Bylokhov <bylokhov at amazon.com>
    Date: Monday, August 16, 2021 at 9:39 PM
    To: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
    Subject: [8u] RFR 8231438 [macos] The dark mode is not supported yet

    Hello,

    Please review the backport of JDK-8231438 to 8u.

    JBS: https://bugs.openjdk.java.net/browse/JDK-8231438
    jdk8u patch: http://cr.openjdk.java.net/~serb/8231438/jdk8u-dev/webrev.00/
    jdk14 patch: http://hg.openjdk.java.net/jdk/jdk14/rev/dae610645225
    jdk14 review: https://mail.openjdk.java.net/pipermail/awt-dev/2019-September/015420.html

    If anybody started to use SDK 10.14+ to build JDK, this automatically opt-in support of dark mode:
    --------------
    "The system assumes that apps linked against the macOS 10.14 or later SDK support both light and 
    dark appearances"
    https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_macos_app?language=objc
    --------------

    Unfortunately the dark mode still unsupported by the AWT/Swing, for a few reasons, example:
    https://bugs.openjdk.java.net/browse/JDK-8228555
    Until the bugs related to the dark mode are not fixed we should opt-out it.

    See the link above to review request for the jdk14 for an additional information.

    The patch does not apply clean, I had to ifdef it only for the sdk 10.14+, so the change will not 
    break the build using old xcode(before sdk 10.9), note that I cannot test the old xcode myself, can 
    somebody verify it?

    -- 
    Best regards, Sergey.