[8u] RFR (S) 8079891: Store configure log in $BUILD/configure.log

[Severin Gehwolf]

On Tue, 2021-07-06 at 14:10 +0200, Aleksey Shipilev wrote:
> On 7/2/21 5:21 PM, Severin Gehwolf wrote:
> > On Tue, 2021-04-27 at 12:01 +0200, Aleksey Shipilev wrote:
> > > Original RFE:
> > >     https://bugs.openjdk.java.net/browse/JDK-8079891
> > >     https://hg.openjdk.java.net/jdk9/jdk9/rev/98e85b507b09
> > > 
> > > I would like to have this simple build feature in 8u to better report configuration logs from 8u
> > > CIs. This patch applies mostly trivially, with the following changes:
> > >     *) Blocks mentioning CONFIGURESUPPORT_OUTPUTDIR are removed, as these are not relevant to 8u
> > > build system;
> > >     *) Minor contextual conflicts are resolved;
> > > 
> > > Current patch needs JDK-8065215 applied first to get the help block at the end of configure. This
> > > also needs JDK-8080082 as the follow-up.
> > > 
> > > Testing: 8u build; observing configure.log in build artifacts
> > 
> > Missing a link to the webrev?
> 
> Right, sorry.
> 
> Here it is (regenerated for the 8u state after JDK-8065215):
>   https://cr.openjdk.java.net/~shade/8079891/webrev.8u.02/

This looks mostly fine. One thing stood out:

common/autoconf/configure.ac

 270 # Make the compare script executable
 271 $CHMOD +x $OUTPUT_ROOT/compare.sh
 272 

These lines are removed in the original patch[1]. As they are, after
patch, in BASIC_POST_CONFIG_OUTPUT anyway, we should also remove.

Thanks,
Severin

[1] https://hg.openjdk.java.net/jdk9/jdk9/rev/98e85b507b09#l3.16