[8u] RFR (S) 8079891: Store configure log in $BUILD/configure.log
Aleksey Shipilev
shade at redhat.com
Tue Jul 6 13:04:44 UTC 2021
On 7/6/21 2:57 PM, Severin Gehwolf wrote:
>> Here it is (regenerated for the 8u state after JDK-8065215):
>> https://cr.openjdk.java.net/~shade/8079891/webrev.8u.02/
>
> This looks mostly fine. One thing stood out:
>
> common/autoconf/configure.ac
>
> 270 # Make the compare script executable
> 271 $CHMOD +x $OUTPUT_ROOT/compare.sh
> 272
>
> These lines are removed in the original patch[1]. As they are, after
> patch, in BASIC_POST_CONFIG_OUTPUT anyway, we should also remove.
Oh right, good catch. I had a weird conflict in those hunks, which I resolved with incorrectly
leaving the $CHMOD line in.
Fixed and regenerated generated-configure.sh:
https://cr.openjdk.java.net/~shade/8079891/webrev.8u.03/
--
Thanks,
-Aleksey
More information about the jdk8u-dev
mailing list