[8u] RFR: JDK-8261867: Backport relevant test changes & additions from JDK-8130125

[Hohensee, Paul]

Thanks, Andrew. Tagged.

Jonathan Dowland notes that we might have missed backporting fixes to Robot.waitForIdle(). Since we already have tests that use it, I propose we push this patch and do any backports to fix waitForIdle() separately.

Thanks,
Paul

-----Original Message-----
From: Andrew Hughes <gnu.andrew at redhat.com>
Date: Tuesday, March 23, 2021 at 11:42 PM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
Subject: RE: [8u] RFR: JDK-8261867: Backport relevant test changes & additions from JDK-8130125

On 23:15 Wed 17 Mar     , Hohensee, Paul wrote:
> Another mistake on my part: your webrev includes the comment change in test/java/awt/Mixing/AWT_Mixing/JSplitPaneOverlapping.java.
>

Yes, your initial comments did confuse me a little :-)

> I added the changes to test/java/awt/Focus/8073453/AWTFocusTransitionTest.java, test/java/awt/Focus/8073453/SwingFocusTransitionTest.java, and test/java/awt/xembed/server/TestXEmbedServer.java. The first two pass as before. The third is a bit unstable, but the manual portion seems more stable than before the change. 
> 
> Webrev: https://cr.openjdk.java.net/~phh/8261867/webrev.8u.jdk.00/
>

Yes, for some reason, I think I was under the delusion it was JDK code, not test code.
As is, it's cleanup that was done for the modules system, but is applicable even before that.

I'm happy for your version to go in if you want to flag it with jdk8u-fix-request.

> Thanks,
> Paul
>

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222