[jdk8u-dev] RFR: 8221988: add possibility to build with Visual Studio 2019

[Christoph Langer]

On Thu, 7 Apr 2022 19:03:44 GMT, Alexey Pavlyutkin <duke at openjdk.java.net> wrote:

> Hi!
> 
> Please review backport of 8221988. This one opens a bunch of backports enabling support of VS2019. The 11u patch applied with the following changes:
> 
> - changes to absent documentation files skipped
> - resolved baseline conflicts toolchain_windows.m4
> 
> Verification: `bash configure` under VS2019 prompt
> Regression: `bash configure` under VS2017 prompt
> 
> @RealCLanger @mdoerr if you take a look at this I will be very grateful

Hi @apavlyutkin,
apart from my other comment I think the backport looks okay. However, I've no means to test it. Probably somebody more involved with OpenJDK 8 (and its Windows build) should have a look...

common/autoconf/toolchain_windows.m4 line 28:

> 26: ################################################################################
> 27: # The order of these defines the priority by which we try to find them.
> 28: VALID_VS_VERSIONS="2017 2019 2013 2015 2012 2010"

I'm not sure whether it's appropriate to put 2017 and 2019 in front of the list - maybe for compatibilities sake we should add 2019 at the end?

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/33