[jdk8u-dev] RFR: 8221988: add possibility to build with Visual Studio 2019

[Alexey Pavlyutkin]

On Fri, 8 Apr 2022 13:21:26 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Hi!
>> 
>> Please review backport of 8221988. This one opens a bunch of backports enabling support of VS2019. The 11u patch applied with the following changes:
>> 
>> - changes to absent documentation files skipped
>> - resolved baseline conflicts toolchain_windows.m4
>> 
>> Verification: `bash configure` under VS2019 prompt
>> Regression: `bash configure` under VS2017 prompt
>> 
>> @RealCLanger @mdoerr if you take a look at this I will be very grateful
>
> common/autoconf/toolchain_windows.m4 line 28:
> 
>> 26: ################################################################################
>> 27: # The order of these defines the priority by which we try to find them.
>> 28: VALID_VS_VERSIONS="2017 2019 2013 2015 2012 2010"
> 
> I'm not sure whether it's appropriate to put 2017 and 2019 in front of the list - maybe for compatibilities sake we should add 2019 at the end?

I completely agree with you but that is how it comes from 11u. I'm not sure if it's a good idea to make such changes as part of the backport. On my last backport to 8u @gnu-andrew made me to eliminate every signle whitespace of unwanted delta.

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/33