[jdk8u-dev] RFR: 8214427: probable bug in logic of ConcurrentHashMap.addCount() [v2]
Andrew John Hughes
andrew at openjdk.org
Sun Jul 10 15:38:52 UTC 2022
On Mon, 4 Jul 2022 09:11:46 GMT, Poison <duke at openjdk.org> wrote:
>> 8214427: probable bug in logic of ConcurrentHashMap.addCount()
>>
>> This backport fixes the problem that the MAX_RESIZERS control does not take effect when multi-threaded expansion in ConcurrentHashMap.
>
> Poison has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into backport-8214427
> - Backport 8846159987f902bb6e2b966eb4656da4b6d9469d
> I've opened a PR for the 11u backport: [openjdk/jdk11u-dev#1114](https://github.com/openjdk/jdk11u-dev/pull/1114)
>
> Can you merge this with jdk8u-dev/master so that the full set of build checks run?
>
> I've see some whitespace differences with the 8u version:
>
> ```
> -+ (nt = nextTable) == null || transferIndex <= 0)
> ++ (nt = nextTable) == null || transferIndex <= 0)
> ```
>
> ```
> -+ transferIndex <= 0)
> ++ transferIndex <= 0)
> ```
>
> Do you see this locally or is it introduced by the `webrev` tool?
>
> The change from `compareAndSetInt` to `compareAndSwapInt` looks correct to match the 8u version.
These whitespace issues are still not resolved in the current patch.
-------------
PR: https://git.openjdk.org/jdk8u-dev/pull/18
More information about the jdk8u-dev
mailing list