[jdk8u-dev] RFR: 8214427: probable bug in logic of ConcurrentHashMap.addCount() [v2]

[Andrew John Hughes]

On Sun, 10 Jul 2022 15:35:39 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Poison has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into backport-8214427
>>  - Backport 8846159987f902bb6e2b966eb4656da4b6d9469d
>
>> I've opened a PR for the 11u backport: [openjdk/jdk11u-dev#1114](https://github.com/openjdk/jdk11u-dev/pull/1114)
>> 
>> Can you merge this with jdk8u-dev/master so that the full set of build checks run?
>> 
>> I've see some whitespace differences with the 8u version:
>> 
>> ```
>> -+                        (nt = nextTable) == null || transferIndex <= 0)
>> ++                            (nt = nextTable) == null || transferIndex <= 0)
>> ```
>> 
>> ```
>> -+                    transferIndex <= 0)
>> ++                        transferIndex <= 0)
>> ```
>> 
>> Do you see this locally or is it introduced by the `webrev` tool?
>> 
>> The change from `compareAndSetInt` to `compareAndSwapInt` looks correct to match the 8u version.
> 
> These whitespace issues are still not resolved in the current patch.

> @gnu-andrew The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer)).

"The requirements are in addition to the ones specified by the .jcheck/conf file. "

Clearly not, because 1 (from jcheck) + 1 (from reviewers command) should equal 2.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/18