[jdk8u-dev] RFR: 8214427: probable bug in logic of ConcurrentHashMap.addCount() [v2]

Poison duke at openjdk.org
Thu Jul 21 06:47:22 UTC 2022


On Sun, 10 Jul 2022 15:35:39 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > I've opened a PR for the 11u backport: [openjdk/jdk11u-dev#1114](https://github.com/openjdk/jdk11u-dev/pull/1114)
> > Can you merge this with jdk8u-dev/master so that the full set of build checks run?
> > I've see some whitespace differences with the 8u version:
> > ```
> > -+                        (nt = nextTable) == null || transferIndex <= 0)
> > ++                            (nt = nextTable) == null || transferIndex <= 0)
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > ```
> > -+                    transferIndex <= 0)
> > ++                        transferIndex <= 0)
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > Do you see this locally or is it introduced by the `webrev` tool?
> > The change from `compareAndSetInt` to `compareAndSwapInt` looks correct to match the 8u version.
> 
> These whitespace issues are still not resolved in the current patch.

Already fixed

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/18


More information about the jdk8u-dev mailing list