[jdk8u-dev] RFR: 8221988: add possibility to build with Visual Studio 2019 [v3]

[Andrew John Hughes]

On Fri, 8 Apr 2022 17:46:57 GMT, Alexey Pavlyutkin <duke at openjdk.java.net> wrote:

>> Hi!
>> 
>> Please review backport of 8221988. This one opens a bunch of backports enabling support of VS2019. **WARNING**: the patch DOES NOT enable the building with MSVS2019 toolkit, that requires 5-6 more backports. The patch ONLY adds recognition of MSVS2019 to the build system.
>> 
>> The 11u patch applied with the following changes:
>> 
>> - changes to absent documentation files skipped
>> - resolved baseline conflicts toolchain_windows.m4
>> - valid MSVS versions were ascending sorted
>> 
>> Verification: `bash configure` under VS2019 prompt.
>> 
>> Regression:
>> 
>> - VS2017 full build (both 64/32-bit): ok
>> - VS2015 full build: ok (requires --with-extra-cflags='/EHsc /wd4091' --with-extra-cxxflags='/EHsc /wd4091')
>> - VS2013 full build: ok
>> - VS2012 full build: ok
>> - VS2010 full build: ok
>> 
>> @RealCLanger @mdoerr if you take a look at this I will be very grateful
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   rearrange valid VS versions

Backport looks good to me and GHA suggests it doesn't break existing builds on VS2010 & VS2017.

There is documentation in 8u but it is in `README-builds.html` and currently only seems to mention VS2010. We should probably do an update of the documentation, starting with a JDK-8176509 backport so it reflects the current status quo, especially after the move to Git. It's fine to leave this change out here though.

-------------

Marked as reviewed by andrew (Reviewer).

PR: https://git.openjdk.java.net/jdk8u-dev/pull/33