[jdk8u-dev] RFR: 8221988: add possibility to build with Visual Studio 2019 [v3]

[Martijn Verburg]

On Fri, 8 Apr 2022 17:46:57 GMT, Alexey Pavlyutkin <duke at openjdk.java.net> wrote:

>> Hi!
>> 
>> Please review backport of 8221988. This one opens a bunch of backports enabling support of VS2019. **WARNING**: the patch DOES NOT enable the building with MSVS2019 toolkit, that requires 5-6 more backports. The patch ONLY adds recognition of MSVS2019 to the build system.
>> 
>> The 11u patch applied with the following changes:
>> 
>> - changes to absent documentation files skipped
>> - resolved baseline conflicts toolchain_windows.m4
>> - valid MSVS versions were ascending sorted
>> 
>> Verification: `bash configure` under VS2019 prompt.
>> 
>> Regression:
>> 
>> - VS2017 full build (both 64/32-bit): ok
>> - VS2015 full build: ok (requires --with-extra-cflags='/EHsc /wd4091' --with-extra-cxxflags='/EHsc /wd4091')
>> - VS2013 full build: ok
>> - VS2012 full build: ok
>> - VS2010 full build: ok
>> 
>> @RealCLanger @mdoerr if you take a look at this I will be very grateful
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   rearrange valid VS versions

Seemed OK with our internal testing FWIW - sorry to be late to the party
here!

Cheers,
Martijn


On Thu, 12 May 2022 at 06:28, openjdk[bot] ***@***.***> wrote:

> @yan-too <https://github.com/yan-too> @apavlyutkin
> <https://github.com/apavlyutkin> Pushed as commit 51f69d9
> <https://github.com/openjdk/jdk8u-dev/commit/51f69d9125e72adaf05fbd04a5ac17a9d2f6c6a0>
> .
>
> �� You may see a message that your pull request was closed with unmerged
> commits. This can be safely ignored.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jdk8u-dev/pull/33#issuecomment-1124544511>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABME2AJONMPQ3Z656Y3AOTVJSJGRANCNFSM5S2KGB4Q>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>

-------------

PR: https://git.openjdk.java.net/jdk8u-dev/pull/33