[jdk8u-dev] RFR: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails [v3]

Joshua Cao duke at openjdk.org
Fri Nov 18 18:06:56 UTC 2022


> Parity with Oracle. This patch is applied on top of https://github.com/openjdk/jdk8u-dev/pull/140. Does not apply cleanly, mostly due to surrounding context missing from the following:
> 
> * https://bugs.openjdk.org/browse/JDK-8210039 (don't think there are plans to backport this to JDK8)
> * https://bugs.openjdk.org/browse/JDK-8159690 (open issue to backport this to 8, but has not been active for >1 year. might get backported)
> 
> Only one serious conflict. We cannot use
> 
> 
> private static int wheelSign = Platform.isOSX() ? -1 : 1;
> 
> 
> Since https://bugs.openjdk.org/browse/JDK-8210039 is missing in JDK8, we don't have 
> 
> 
> import jdk.test.lib.Platform;
> 
> 
> Alternatively, I use the old code to get OS:
> 
> 
> private static int wheelSign = OSInfo.getOSType().equals(OSInfo.OSType.MACOSX) ? -1 : 1;

Joshua Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8129827
 - 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
 - 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/141/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/141/files/f144ec00..df904813

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=141&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=141&range=01-02

  Stats: 5334 lines in 91 files changed: 2981 ins; 1611 del; 742 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/141.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/141/head:pull/141

PR: https://git.openjdk.org/jdk8u-dev/pull/141


More information about the jdk8u-dev mailing list