[jdk8u-dev] Integrated: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails

Joshua Cao duke at openjdk.org
Fri Nov 18 20:17:59 UTC 2022


On Sun, 16 Oct 2022 05:39:23 GMT, Joshua Cao <duke at openjdk.org> wrote:

> Parity with Oracle. This patch is applied on top of https://github.com/openjdk/jdk8u-dev/pull/140. Does not apply cleanly, mostly due to surrounding context missing from the following:
> 
> * https://bugs.openjdk.org/browse/JDK-8210039 (don't think there are plans to backport this to JDK8)
> * https://bugs.openjdk.org/browse/JDK-8159690 (open issue to backport this to 8, but has not been active for >1 year. might get backported)
> 
> Only one serious conflict. We cannot use
> 
> 
> private static int wheelSign = Platform.isOSX() ? -1 : 1;
> 
> 
> Since https://bugs.openjdk.org/browse/JDK-8210039 is missing in JDK8, we don't have 
> 
> 
> import jdk.test.lib.Platform;
> 
> 
> Alternatively, I use the old code to get OS:
> 
> 
> private static int wheelSign = OSInfo.getOSType().equals(OSInfo.OSType.MACOSX) ? -1 : 1;

This pull request has now been integrated.

Changeset: 91d8b89a
Author:    Joshua Cao <joshcao at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/91d8b89ab976a8c25484da23ded6cdbb86f7b1e5
Stats:     42 lines in 1 file changed: 32 ins; 5 del; 5 mod

8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails

Reviewed-by: phh
Backport-of: a1efb95536fb3995780336604cc727f921770c63

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/141


More information about the jdk8u-dev mailing list