[jdk8u-dev] RFR: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0 [v3]

Olga Mikhaltsova omikhaltcova at openjdk.org
Thu Oct 13 12:55:11 UTC 2022


> I'd like to backport JDK-8269850 to jdk8u in order to fix the incorrect version detection for macOS.
> 
> The patch applied manually due to the location difference:
> src/java.base/macosx/native/libjava/java_props_macosx.c (source)
> jdk/src/solaris/native/java/lang/java_props_macosx.c (destination)
> But it's small and low risk. The changes are related only to one function void setOSNameAndVersion(..) within the single file. The patch is identical to the original one.
> 
> Tested with a simple test printing the OS version on macOS Monterey:
> 
> public class Main {
>     public static void main(String[] args) {
>         System.out.println(System.getProperty("os.version"));
>     }
> }

Olga Mikhaltsova has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge master
 - Backport 3b1b8fc646493eae5f4df828afe29abb75fa5e60
 - Backport 66757750a2adf0739d0f5bf98a3f50a123b7adcf

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/126/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/126/files/275e333b..99e6a341

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=126&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=126&range=01-02

  Stats: 497 lines in 4 files changed: 169 ins; 218 del; 110 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/126.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/126/head:pull/126

PR: https://git.openjdk.org/jdk8u-dev/pull/126


More information about the jdk8u-dev mailing list