[jdk8u-dev] RFR: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec

[Volker Simonis]

On Wed, 12 Apr 2023 23:20:36 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> The backport from 11u was not clean because:
> 
> 1. the change to PKCS11Test.java affects code that does not exist in 8u, so is not included
> 2. the new test, TestP11KeyFactoryGetRSAKeySpec.java, uses /lib/testlibrary instead of /test/lib
> 
> The new test and the modified existing tests pass, and the jdk/test/sun/security/pkcs11 tests pass as well as they did before this change.

Looks good except for a small cosmetic issue in `p11-nss-sensitive.txt`.

jdk/test/sun/security/pkcs11/nss/p11-nss-sensitive.txt line 23:

> 21:   CKM_DSA_SHA3_256
> 22:   CKM_DSA_SHA3_384
> 23:   CKM_DSA_SHA3_512

These `*_SHA3_*` entries here and below have been removed from the 11u-dev downport because SHA3 support was only [introduced in JDK 16](https://bugs.openjdk.org/browse/JDK-8242332) (see [the 11u review thread](https://mail.openjdk.org/pipermail/jdk-updates-dev/2021-May/006096.html)).

I suggest to remove them here as well to be on par with the 11u downport.

-------------

Changes requested by simonis (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/302#pullrequestreview-1383235158
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/302#discussion_r1165407289