[jdk8u-dev] RFR: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec [v2]

[Andrew John Hughes]

On Thu, 13 Apr 2023 11:58:14 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> jdk/test/sun/security/pkcs11/nss/p11-nss-sensitive.txt line 23:
>> 
>>> 21:   CKM_DSA_SHA3_256
>>> 22:   CKM_DSA_SHA3_384
>>> 23:   CKM_DSA_SHA3_512
>> 
>> These `*_SHA3_*` entries here and below have been removed from the 11u-dev downport because SHA3 support was only [introduced in JDK 16](https://bugs.openjdk.org/browse/JDK-8242332) (see [the 11u review thread](https://mail.openjdk.org/pipermail/jdk-updates-dev/2021-May/006096.html)).
>> 
>> I suggest to remove them here as well to be on par with the 11u downport.
>
> Done.

They should be kept. The definitions are added by JDK-8244154, not JDK-8242332. You said the tests passed before they were removed, right?

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/302#discussion_r1165625274