[jdk8u-dev] RFR: 8305113: (tz) Update Timezone Data to 2023c [v2]

[Andrew John Hughes]

On Fri, 14 Apr 2023 02:46:43 GMT, Victor Rudometov <vrudomet at openjdk.org> wrote:

>> Update to the latest tzdata 2023c. https://bugs.openjdk.org/browse/JDK-8305113
>> 
>> Similar fix to 11/17, but not a clean backport as 8 uses different format.
>> Tested: jdk/test/java/util/TimeZone jdk/test/java/time/test jdk/test/sun/util/resources jdk/test/sun/text/resources jdk/test/sun/util/calendar Test results: passed: 123
>> 
>> Jtreg tier1, tier2 ok
>
> Victor Rudometov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8305113: (tz) Update Timezone Data to 2023c

Thanks for dropping the other change. The rearguard data looks good. The duplication in `ZoneInfoFile.java` just needs to be fixed (see other comment) and then this is good to go.

jdk/src/share/classes/sun/util/calendar/ZoneInfoFile.java line 647:

> 645:                     params[7] = Calendar.THURSDAY;
> 646:                     params[8] = SECONDS_PER_DAY * 1000;
> 647:                 }

This actually needs to replace the block above, which is:
~~~
                //endDayOfWeek and endTime workaround                                                                                                       
                if (params[7] == 6 && params[8] == 0 &&
                    (zoneId.equals("Africa/Cairo"))) {
                    params[7] = 5;
                    params[8] = 86400000;
                }
~~~
i.e. the same thing but using hardcoded values rather than constants.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/305#pullrequestreview-1385895735
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/305#discussion_r1167110125