[jdk8u-dev] RFR: 8305113: (tz) Update Timezone Data to 2023c [v2]
Victor Rudometov
vrudomet at openjdk.org
Fri Apr 14 19:53:42 UTC 2023
On Fri, 14 Apr 2023 17:25:50 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:
>> Victor Rudometov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
>>
>> 8305113: (tz) Update Timezone Data to 2023c
>
> jdk/src/share/classes/sun/util/calendar/ZoneInfoFile.java line 647:
>
>> 645: params[7] = Calendar.THURSDAY;
>> 646: params[8] = SECONDS_PER_DAY * 1000;
>> 647: }
>
> This actually needs to replace the block above, which is:
> ~~~
> //endDayOfWeek and endTime workaround
> if (params[7] == 6 && params[8] == 0 &&
> (zoneId.equals("Africa/Cairo"))) {
> params[7] = 5;
> params[8] = 86400000;
> }
> ~~~
> i.e. the same thing but using hardcoded values rather than constants.
Thank you for the review. Removed the dup code mentioned, pushed commit [Code clean up](https://github.com/openjdk/jdk8u-dev/pull/305/commits/90d26a57fe1f67a9efaf1e4b1894f046037bb941)
Rerun build/tests, all look good.
-------------
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/305#discussion_r1167225504
More information about the jdk8u-dev
mailing list