[jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows [v3]

Jiří Vaněk jvanek at openjdk.org
Thu Feb 2 08:53:36 UTC 2023


On Wed, 1 Feb 2023 17:00:30 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved to testlibray's  paltfrom isntead of custom proeprty chekcing
>
> Hm. It do not work. The library is not found. It seems to me, that in jdk_jfr  target is unable to locate it no metter of what I do. Can we go back to  to property?

> @judovana for Platform class I linked it would need to be `@library /lib/testlibrary`, I think. Path is relative to `TEST.ROOT`. I accidentally posted example from hotspot, which has it's copy of that class placed a bit differently. Note that there is also another copy of whole test library in jdk (including Platform class), which came with jfr backport [1]. It is placed directly in `/lib` and uses package `jdk.test.lib`. This is a one you currently switched to. Tests in JDK 8 are unfortunately a bit messy.
> 
> [1] [df7e090](https://github.com/openjdk/jdk8u-dev/commit/df7e09043392d5952d522a28702c6e5ec3e8492e)

Indeed. the test now passes. Although I was originally not aware of the copy of library in hotspot.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/255


More information about the jdk8u-dev mailing list