[jdk8u-dev] RFR: 8287463: JFR: Disable TestDevNull.java on Windows [v3]

[Jiří Vaněk]

On Thu, 2 Feb 2023 08:50:33 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> Hm. It do not work. The library is not found. It seems to me, that in jdk_jfr  target is unable to locate it no metter of what I do. Can we go back to  to property?
>
>> @judovana for Platform class I linked it would need to be `@library /lib/testlibrary`, I think. Path is relative to `TEST.ROOT`. I accidentally posted example from hotspot, which has it's copy of that class placed a bit differently. Note that there is also another copy of whole test library in jdk (including Platform class), which came with jfr backport [1]. It is placed directly in `/lib` and uses package `jdk.test.lib`. This is a one you currently switched to. Tests in JDK 8 are unfortunately a bit messy.
>> 
>> [1] [df7e090](https://github.com/openjdk/jdk8u-dev/commit/df7e09043392d5952d522a28702c6e5ec3e8492e)
> 
> Indeed. the test now passes. Although I was originally not aware of the copy of library in hotspot.

> @judovana maybe it's better to use `@requires (os.family != "windows")` similar to the original test and not change the code of the test? As I can see it works fine for jdk8 as well.

The `@requires` comes from jtreg library. Alhough you can supply newer jtreg library, the minimal version enforced by jdl8 had not supported @requires; but after additional reading I think it already does support @requires. Will return the os.family as in original fix.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/255