[jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2]

[Andrew John Hughes]

On Wed, 18 Jan 2023 08:44:22 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport.
> 

As far as I can see, the [11u backport](https://github.com/openjdk/jdk11u-dev/commit/3e65a7c5d35b82e14b549ee8ea4bf3a49cfec2e3#diff-50dba36cc764382a6c70482237ced2794f3c7edf695b596a5b64070d4090fb74) still had text blocks. Do you mean you've also included the changes in [JDK-8299445](https://bugs.openjdk.org/browse/JDK-8299445) here? If so, we should reference it too.

> Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation.
> 
> Force-pushed to keep the commit history clean to make reviewing easier.

Thanks for removing the superfluous module line.

Is there a reason the custom `NameService` creates an `InetAddress` using an internal API rather than just returning `InetAddress.getLoopbackAddress()` which would be closer to the 11u code?

Has the test been run successfully on 8u? The follow-up fix on 11u suggests this wasn't done before committing the fix to 11u.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/207