[jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2]

Roman Marchenko rmarchenko at openjdk.org
Wed Feb 8 08:35:51 UTC 2023


On Tue, 7 Feb 2023 16:47:43 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> As far as I can see, the [11u backport](https://github.com/openjdk/jdk11u-dev/commit/3e65a7c5d35b82e14b549ee8ea4bf3a49cfec2e3#diff-50dba36cc764382a6c70482237ced2794f3c7edf695b596a5b64070d4090fb74) still had text blocks. Do you mean you've also included the changes in [JDK-8299445](https://bugs.openjdk.org/browse/JDK-8299445) here? If so, we should reference it too.

Thanks, I added the reference.

> Is there a reason the custom `NameService` creates an `InetAddress` using an internal API rather than just returning `InetAddress.getLoopbackAddress()` which would be closer to the 11u code?

Sounds reasonable, thanks. I've updated the code.

> Has the test been run successfully on 8u? The follow-up fix on 11u suggests this wasn't done before committing the fix to 11u.

Yes, it passes successfully on my Win11/Cygwin.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/207


More information about the jdk8u-dev mailing list