[jdk8u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2]

Andrew John Hughes andrew at openjdk.org
Thu Feb 9 01:15:55 UTC 2023


On Wed, 18 Jan 2023 07:59:10 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Test files changed only.
>> 
>> The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport.
>> 
>> Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation.
>> 
>> There were 2 changes with test files paths:
>> 
>> - Original `test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java` path changed to `jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java`.
>> - Original `test/jdk/javax/net/ssl/templates/SSLExampleCert.java` path changed to `jdk/test/javax/net/ssl/templates/SSLExampleCert.java`.
>> 
>> Please note that this PR is a part of dependant PR chain
>> Prev PRs:
>> - #205 
>> - #206
>
> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase.

jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java line 29:

> 27:  * @summary Trailing dot in hostname causes TLS handshake to fail
> 28:  * @library /javax/net/ssl/templates
> 29:  * @run main/othervm --add-opens java.base/sun.security.ssl=ALL-UNNAMED

Does this test pass on 8u? `--add-opens` is not supported on 8u (no modules) so this change isn't needed.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/207


More information about the jdk8u-dev mailing list