[jdk8u-dev] RFR: 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper
Jiří Vaněk
jvanek at openjdk.org
Mon Feb 13 11:44:30 UTC 2023
On Tue, 24 Jan 2023 16:12:14 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
> This test was brought in by 8223147: JFR Backport and never passed. Despite not being wrong nor having jfr broken in jdk8. jdk8 testsuite simply lacks native support cases.
>
> This is adding the shell wrapper which is compiling and properly setting up the native longSleep in native shared object.
>
> This commit was tested only on linux.
> After this commit whole jdk_jfr group passes
@egahlin , @mgronlun - although not an jdk8 reviewrs, may you eyball please?
@phohensee , may I be so bold and kindly ask you for official review? (sorry, you popped out in https://github.com/openjdk/jdk8u-dev/pull/234)
-------------
PR: https://git.openjdk.org/jdk8u-dev/pull/235
More information about the jdk8u-dev
mailing list