[jdk8u-dev] RFR: 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper

[Severin Gehwolf]

On Tue, 24 Jan 2023 16:12:14 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

> This test was brought in by 8223147: JFR Backport and never passed. Despite not being wrong nor having jfr broken in jdk8. jdk8 testsuite simply lacks native support cases.
> 
> This is adding the shell wrapper which is compiling and properly setting up the native longSleep  in native shared object.
> 
> This commit was tested only on linux.
> After this commit whole jdk_jfr group passes

Looks OK to me.

jdk/test/jdk/jfr/event/sampling/TestNative.sh line 34:

> 32: TEST_ENV_SH="${JDK_TOPDIR}/../hotspot/test/test_env.sh"
> 33: 
> 34: ls -l "${TEST_ENV_SH}"

This looks like a debug aid. Please remove before pushing.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk8u-dev/pull/235