[jdk8u-dev] RFR: 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper

Severin Gehwolf sgehwolf at openjdk.org
Thu Feb 16 14:42:38 UTC 2023


On Thu, 16 Feb 2023 13:24:19 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> jdk/test/jdk/jfr/event/sampling/TestNative.sh line 34:
>> 
>>> 32: TEST_ENV_SH="${JDK_TOPDIR}/../hotspot/test/test_env.sh"
>>> 33: 
>>> 34: ls -l "${TEST_ENV_SH}"
>> 
>> This looks like a debug aid. Please remove before pushing.
>
> Nope. It is here to fail the test if the file is missing.
> See below, the +e/ source -e - the test_env.sh is not designed to run with -e. 
> 
> Ok to go  with this in?

Fair enough. Feel free to proceed.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/235


More information about the jdk8u-dev mailing list