[jdk8u-dev] RFR: 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper

[Jiří Vaněk]

On Thu, 16 Feb 2023 13:12:54 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> This test was brought in by 8223147: JFR Backport and never passed. Despite not being wrong nor having jfr broken in jdk8. jdk8 testsuite simply lacks native support cases.
>> 
>> This is adding the shell wrapper which is compiling and properly setting up the native longSleep  in native shared object.
>> 
>> This commit was tested only on linux.
>> After this commit whole jdk_jfr group passes
>
> jdk/test/jdk/jfr/event/sampling/TestNative.sh line 34:
> 
>> 32: TEST_ENV_SH="${JDK_TOPDIR}/../hotspot/test/test_env.sh"
>> 33: 
>> 34: ls -l "${TEST_ENV_SH}"
> 
> This looks like a debug aid. Please remove before pushing.

Nope. It is here to fail the test if the file is missing.
See below, the +e/ source -e - the test_env.sh is not designed to run with -e. 

Ok to go  with this in?

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/235