[jdk8u] RFR: 8186801: Add regression test to test mapping based charsets (generated at build time)

[Thomas Stuefe]

On Thu, 22 Jun 2023 11:22:23 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> jdk/test/sun/nio/cs/TestCharsetMapping.java line 549:
>> 
>>> 547:             } else {
>>> 548:                 cs.type = tokens[3];
>>> 549:             }
>> 
>> Mentally parsing:
>> 
>> Format 1, dbcs:
>> clzName  csName     hisName  dbtype    pkg               ascii   b1min  b1max  b2min b2max
>> 
>> hisname = 2
>> pkgName = 4
>> type = sbcs
>> 
>> Format 2, sbcs and extsbcs:
>> clzName	csName		hisName		containASCII	pkg
>> 
>> hisname = 2
>> pkgName = 4
>> type = sbcs
>> 
>> Okay, checks out.
>
> Could you add a small comment here, listing these two formats for easier code reading:
> 
> 
> // dbcs format
> // clzName csName hisName dbtype pkg ascii b1min b1max b2min b2max
> // sbcs format
> //  clzName csName hisName containASCII pkg
> 
> 
> ?

Maybe also some sanity tests:
- pkgname to start with "sun.nio"
- type one of "basic ebcdic euc_sim dbcsonly sbcs"

-------------

PR Review Comment: https://git.openjdk.org/jdk8u/pull/43#discussion_r1238392147