[jdk8u] RFR: 8186801: Add regression test to test mapping based charsets (generated at build time)
Andrew John Hughes
andrew at openjdk.org
Fri Jun 23 02:27:12 UTC 2023
On Thu, 22 Jun 2023 11:25:00 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Could you add a small comment here, listing these two formats for easier code reading:
>>
>>
>> // dbcs format
>> // clzName csName hisName dbtype pkg ascii b1min b1max b2min b2max
>> // sbcs format
>> // clzName csName hisName containASCII pkg
>>
>>
>> ?
>
> Maybe also some sanity tests:
> - pkgname to start with "sun.nio"
> - type one of "basic ebcdic euc_sim dbcsonly sbcs"
The comment is a good idea. I was looking at that line in the mapping file as I was writing the code, and it would be good to have it in there directly.
I think the sanity tests are something we should add in mainline first and backport, as both would apply there too (though mainline has a few more types).
-------------
PR Review Comment: https://git.openjdk.org/jdk8u/pull/43#discussion_r1239255377
More information about the jdk8u-dev
mailing list