[jdk8u-dev] RFR: 8317291: Missing null check for nmethod::is_native_method()

[Paul Hohensee]

On Fri, 29 Sep 2023 04:15:09 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

> I added null check to nmethod::is_native_method() and is_java_method().
> I verified that the JVM crash problem no longer occurs by this fix.
> I don't attach the test for this fix beause I could reproduce this problem only with debug build.
> 
> Would anyone review this fix, pelase?

Marked as reviewed by phh (Reviewer).

The original commit containing this two-line change is at https://hg.openjdk.org/jdk9/jdk9/hotspot/rev/69d081845165 and very large. Which imo justifies a separate PR for 8.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/379#pullrequestreview-1704685208
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/379#issuecomment-1785695648