[jdk8u-dev] RFR: 8317291: Missing null check for nmethod::is_native_method()

KIRIYAMA Takuya duke at openjdk.org
Tue Oct 31 09:19:46 UTC 2023


On Mon, 30 Oct 2023 17:16:00 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> I added null check to nmethod::is_native_method() and is_java_method().
>> I verified that the JVM crash problem no longer occurs by this fix.
>> I don't attach the test for this fix beause I could reproduce this problem only with debug build.
>> 
>> Would anyone review this fix, pelase?
>
> The original commit containing this two-line change is at https://hg.openjdk.org/jdk9/jdk9/hotspot/rev/69d081845165 and very large. Which imo justifies a separate PR for 8.

@phohensee 
Thanks! I enabled it and all tests passed.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/379#issuecomment-1786811340


More information about the jdk8u-dev mailing list