[jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9]

Sergey Bylokhov serb at openjdk.org
Thu Aug 15 23:18:58 UTC 2024


On Thu, 15 Aug 2024 07:23:27 GMT, George Adams <gdams at openjdk.org> wrote:

>> Imports the Freetype source to be consistent with JDK11+
>> 
>> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew
>
> George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into freetype
>  - remove top level make changes
>  - remove make/conf/jib-profiles.js
>  - changes from review
>  - rerun autoconf
>  - Merge remote-tracking branch 'upstream/master' into freetype
>  - Merge remote-tracking branch 'upstream/master' into freetype
>  - move libfreetype to correct src directory
>  - remove freetype from actions
>  - and more changes
>  - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c

common/autoconf/toolchain_windows.m4 line 160:

> 158:         # 'v110' or 'v120' for VS 2010, 2012 or VS2013
> 159:         eval PLATFORM_TOOLSET="\${VS_VS_PLATFORM_NAME_${VS_VERSION}}"
> 160: 

this change probably correct, but it is not part of the jdk11 [commit](https://github.com/openjdk/jdk/commit/58ff4ee8c4ec399528338b59eadea996110366a0#diff-098656ab8708ea86ee2cc19047997ed8f58caf22b2d239630276329fae933269), and this code still exists in the [openjdk/jdk](https://github.com/openjdk/jdk/blob/74066bcca82749722e6fee57469520d418bf3430/make/autoconf/toolchain_microsoft.m4#L105)

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719103616


More information about the jdk8u-dev mailing list