[jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12]

[George Adams]

On Thu, 15 Aug 2024 23:16:35 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> George Adams has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test removal of common/autoconf/toolchain_windows.m4 changes
>
> common/autoconf/toolchain_windows.m4 line 160:
> 
>> 158: ])
>> 159: 
>> 160: ################################################################################
> 
> this change probably correct, but it is not part of the jdk11 [commit](https://github.com/openjdk/jdk/commit/58ff4ee8c4ec399528338b59eadea996110366a0#diff-098656ab8708ea86ee2cc19047997ed8f58caf22b2d239630276329fae933269), and this code still exists in the [openjdk/jdk](https://github.com/openjdk/jdk/blob/74066bcca82749722e6fee57469520d418bf3430/make/autoconf/toolchain_microsoft.m4#L105)

good spot, I've pushed a commit to revert this and will see if a build still passes

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719561999