[jdk8u-dev] RFR: 8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"
ktakakuri
duke at openjdk.org
Fri Jan 26 05:38:40 UTC 2024
Hi all, This is a backport of JDK-8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging".
I worked on backporting JDK-8159695 to jdk8u ( https://github.com/openjdk/jdk8u-dev/pull/428 ), and found that VS2010 build fails. This is because strtoull function, which the JDK-8159695 patch contains, is not predefined in VS2010. This patch defines strtoull macro when the earlier versions of Visual Studio are used, so this patch need to be backported for builing with VS2010 if JDK-8159695 is backported as proposed.
This patch couldn't be applied cleanly due to a previously backported fix for earlier versions of Visual Studio at the same location, which needs to be merged.
The risk is low as this only affects earlier VS builds and introduces one macro.
Testing: GHA
Thank you.
-------------
Depends on: https://git.openjdk.org/jdk8u-dev/pull/428
Commit messages:
- Backport 6c113577e63d359a78ed72e5f37919da26b2f20d
Changes: https://git.openjdk.org/jdk8u-dev/pull/434/files
Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=434&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8137329
Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk8u-dev/pull/434.diff
Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/434/head:pull/434
PR: https://git.openjdk.org/jdk8u-dev/pull/434
More information about the jdk8u-dev
mailing list