[jdk8u-dev] RFR: 8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"

[Thomas Stuefe]

On Fri, 26 Jan 2024 05:33:52 GMT, ktakakuri <duke at openjdk.org> wrote:

> Hi all, This is a backport of JDK-8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging".
> I worked on backporting JDK-8159695 to jdk8u ( https://github.com/openjdk/jdk8u-dev/pull/428 ), and found that VS2010 build fails. This is because strtoull function, which the JDK-8159695 patch contains, is not predefined in VS2010. This patch defines strtoull macro when the earlier versions of Visual Studio are used, so this patch need to be backported for builing with VS2010 if JDK-8159695 is backported as proposed.
> 
> This patch couldn't be applied cleanly due to a previously backported fix for earlier versions of Visual Studio at the same location, which needs to be merged.
> 
> The risk is low as this only affects earlier VS builds and introduces one macro.  
> Testing: GHA
> 
> Thank you.

Okay.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/434#pullrequestreview-1845095807