[jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16

[Zdenek Zambersky]

On Fri, 12 Jul 2024 10:51:34 GMT, George Adams <gdams at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> This will remove all warnings about deprecated Node.js versions

I remember I was looking a bit into this in the past. And there were some problems with `actions/upload-artifact at v4`, as there seem to be some [braking change](https://github.com/actions/upload-artifact/issues/478) in v4 (from v3).

See [errors](https://github.com/gdams/jdk8u-dev/actions/runs/9906731382) in sumary (annotations):

Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run


It seems to have effect on produced artifacts (bottom of the page), compare with e.g.:
https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012

With existing actions it produces just one `test-results` artifact, which is relatively small (<200MiB), while with updated 
actions there are some additional (leftover?) artifacts and test-results is huge (1.49GiB).

Looking at contents of `test-results` with updated actions, it's is wrong. It does not contain results of all tests, as it should, and wrongly contains built jdk binaries...

However I haven't looked into detail, why that is. Or how difficult would it be to fix this.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2231126748