[jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16

[Zdenek Zambersky]

On Fri, 12 Jul 2024 10:51:34 GMT, George Adams <gdams at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> This will remove all warnings about deprecated Node.js versions

It seems, there were some [significant changes](https://github.com/actions/upload-artifact?tab=readme-ov-file#v4---whats-new) in artifact actions v4. (causing compatibility problems with previous versions)

I took a deeper look and there are actually 2 issues here:

**1. Upload of test results**
 -  artifact name is not specified (in upload-artifact) for test results uploads -> default artifact name ("artifact") is then used
 - upload-artifact v4 can no longer upload multiple times (append) to the same artifact -> error messages, missing archives with results
 - can be easily [fixed](https://github.com/zzambers/jdk8u-dev/commit/b5abfa7111d1c1360de8b43e5d7a0200c77ef569) by explicitly specifying artifact name for testresults
 
**2. Artifact removal does not work**
  - [current code](https://github.com/openjdk/jdk8u-dev/blob/f231e27d90dd282355b5776653af20ca04f75591/.github/workflows/submit.yml#L1589), to remove unnecessary artifacts, no longer works with artifacts uploaded by `upload-artifact at v4` 
  - also affects newer jdks, I have crated bug and fix (see [JDK-8336928](https://bugs.openjdk.org/browse/JDK-8336928))

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2243842053